[FFmpeg-devel] [PATCH] huffyuv: make VLAs fixed size

Måns Rullgård mans
Fri Jun 25 21:28:16 CEST 2010


Michael Niedermayer <michaelni at gmx.at> writes:

> On Fri, Jun 25, 2010 at 07:33:21PM +0100, M?ns Rullg?rd wrote:
>> Michael Niedermayer <michaelni at gmx.at> writes:
>> 
>> > On Fri, Jun 25, 2010 at 02:54:43AM +0100, Mans Rullgard wrote:
>> >> ---
>> >>  libavcodec/huffyuv.c |    6 +++---
>> >>  1 files changed, 3 insertions(+), 3 deletions(-)
>> >> 
>> >> diff --git a/libavcodec/huffyuv.c b/libavcodec/huffyuv.c
>> >> index 7764c35..f5125b6 100644
>> >> --- a/libavcodec/huffyuv.c
>> >> +++ b/libavcodec/huffyuv.c
>> >> @@ -232,9 +232,9 @@ static void heap_sift(HeapElem *h, int root, int size)
>> >>  }
>> >>  
>> >>  static void generate_len_table(uint8_t *dst, const uint64_t *stats, int size){
>> >> -    HeapElem h[size];
>> >> -    int up[2*size];
>> >> -    int len[2*size];
>> >> +    HeapElem h[256];
>> >> +    int up[2*256];
>> >> +    int len[2*256];
>> >
>> > ok
>> 
>> Applied.
>> 
>> > and the int size probably should be removed as its always 256 and
>> > this will likely not work if its >256
>> 
>> Like this?
>
> yes

Applied.

-- 
M?ns Rullg?rd
mans at mansr.com



More information about the ffmpeg-devel mailing list