[FFmpeg-devel] [PATCH] huffyuv: make VLAs fixed size

Michael Niedermayer michaelni
Fri Jun 25 21:21:47 CEST 2010


On Fri, Jun 25, 2010 at 07:33:21PM +0100, M?ns Rullg?rd wrote:
> Michael Niedermayer <michaelni at gmx.at> writes:
> 
> > On Fri, Jun 25, 2010 at 02:54:43AM +0100, Mans Rullgard wrote:
> >> ---
> >>  libavcodec/huffyuv.c |    6 +++---
> >>  1 files changed, 3 insertions(+), 3 deletions(-)
> >> 
> >> diff --git a/libavcodec/huffyuv.c b/libavcodec/huffyuv.c
> >> index 7764c35..f5125b6 100644
> >> --- a/libavcodec/huffyuv.c
> >> +++ b/libavcodec/huffyuv.c
> >> @@ -232,9 +232,9 @@ static void heap_sift(HeapElem *h, int root, int size)
> >>  }
> >>  
> >>  static void generate_len_table(uint8_t *dst, const uint64_t *stats, int size){
> >> -    HeapElem h[size];
> >> -    int up[2*size];
> >> -    int len[2*size];
> >> +    HeapElem h[256];
> >> +    int up[2*256];
> >> +    int len[2*256];
> >
> > ok
> 
> Applied.
> 
> > and the int size probably should be removed as its always 256 and
> > this will likely not work if its >256
> 
> Like this?

yes


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The real ebay dictionary, page 1
"Used only once"    - "Some unspecified defect prevented a second use"
"In good condition" - "Can be repaird by experienced expert"
"As is" - "You wouldnt want it even if you were payed for it, if you knew ..."
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100625/6506c1dc/attachment.pgp>



More information about the ffmpeg-devel mailing list