[FFmpeg-devel] [PATCH] alac: change VLAs to fixed size

Måns Rullgård mans
Thu Jun 24 10:27:05 CEST 2010


Jai Menon <jmenon86 at gmail.com> writes:

> On Thu, Jun 24, 2010 at 2:34 AM, Mans Rullgard <mans at mansr.com> wrote:
>> ---
>> ?libavcodec/alac.c | ? 10 +++++-----
>> ?1 files changed, 5 insertions(+), 5 deletions(-)
>>
>> diff --git a/libavcodec/alac.c b/libavcodec/alac.c
>> index 50fc7a1..07b03c1 100644
>> --- a/libavcodec/alac.c
>> +++ b/libavcodec/alac.c
>> @@ -547,11 +547,11 @@ static int alac_decode_frame(AVCodecContext *avctx,
>>
>> ? ? if (!isnotcompressed) {
>> ? ? ? ? /* so it is compressed */
>> - ? ? ? ?int16_t predictor_coef_table[channels][32];
>> - ? ? ? ?int predictor_coef_num[channels];
>> - ? ? ? ?int prediction_type[channels];
>> - ? ? ? ?int prediction_quantitization[channels];
>> - ? ? ? ?int ricemodifier[channels];
>> + ? ? ? ?int16_t predictor_coef_table[MAX_CHANNELS][32];
>> + ? ? ? ?int predictor_coef_num[MAX_CHANNELS];
>> + ? ? ? ?int prediction_type[MAX_CHANNELS];
>> + ? ? ? ?int prediction_quantitization[MAX_CHANNELS];
>> + ? ? ? ?int ricemodifier[MAX_CHANNELS];
>> ? ? ? ? int i, chan;
>>
>> ? ? ? ? interlacing_shift = get_bits(&alac->gb, 8);
>> --
>> 1.7.1
>
> This should be just fine. though i'm not the maintainer

Applied anyway.  It seems trivial enough.

-- 
M?ns Rullg?rd
mans at mansr.com



More information about the ffmpeg-devel mailing list