[FFmpeg-devel] [PATCH 03/12] mdct: remove temporary array in ff_kbd_window_init()

[Måns Rullgård]

Michael Niedermayer <michaelni at gmx.at> writes:

> On Wed, Jun 23, 2010 at 06:26:41PM +0100, Mans Rullgard wrote:
>> The intermediate values can be stored in the output array, avoiding
>> the need for a variable-length array.
>
> this can write into static arrays and thus introduces a race condition

Quite.  Which would you prefer then, 1) malloc/free or, 2) always
allocating a [1024] array (largest size used)?  Option 2 would use 4k
(float) or 8k (double) of stack space, which is IMO a bit larger than
what's comfortable.  It would of course not change anything compared
to current code so should be safe.

-- 
M?ns Rullg?rd
mans at mansr.com