[FFmpeg-devel] [PATCH] mpeg2: fix block_last_index when mismatch control modifies last coeff

[Michael Niedermayer]

On Tue, Jun 22, 2010 at 10:57:08PM +0100, M?ns Rullg?rd wrote:
> Michael Niedermayer <michaelni at gmx.at> writes:
> 
> > On Tue, Jun 22, 2010 at 09:46:35PM +0100, M?ns Rullg?rd wrote:
> >> Michael Niedermayer <michaelni at gmx.at> writes:
[...]
> >> >> Index: libavcodec/h264.h
> >> >> ===================================================================
> >> >> --- libavcodec/h264.h	(revision 23459)
> >> >> +++ libavcodec/h264.h	(working copy)
> >> >> @@ -735,22 +735,6 @@
> >> >>   1+5*8, 2+5*8,
> >> >>  };
> >> >>  
> >> >> -static av_always_inline uint32_t pack16to32(int a, int b){
> >> >> -#if HAVE_BIGENDIAN
> >> >> -   return (b&0xFFFF) + (a<<16);
> >> >> -#else
> >> >> -   return (a&0xFFFF) + (b<<16);
> >> >> -#endif
> >> >> -}
> >> >> -
> >> >> -static av_always_inline uint16_t pack8to16(int a, int b){
> >> >> -#if HAVE_BIGENDIAN
> >> >> -   return (b&0xFF) + (a<<8);
> >> >> -#else
> >> >> -   return (a&0xFF) + (b<<8);
> >> >> -#endif
> >> >> -}
> >> >> -
> >> >
> >> > moving these or anything else to a common place is ok of course
> >> 
> >> I suggest alongside the 8x4 Ronald added today.
> >
> > just keep track which of these work with negative numbers and which not
> 
> Maybe we should have one of each to avoid needless masking:
> 
> PACK_2S8
> PACK_2U8
> PACK_4S8
> PACK_4U8
> PACK_2S16
> PACK_2U16

fine with me

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Thouse who are best at talking, realize last or never when they are wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100623/29f2d08d/attachment.pgp>