[FFmpeg-devel] [PATCH] VP8 decoder

[Ronald S. Bultje]

Hi,

2010/6/22 M?ns Rullg?rd <mans at mansr.com>:
> "Ronald S. Bultje" <rsbultje at gmail.com> writes:
>> +#ifndef PACK4x8
>> +#define PACK4x8(a,b,c,d) \
>> + ? ?HAVE_BIGENDIAN ? (a << 24) | (b << 16) | (c << 8) | d : \
>> + ? ? ? ? ? ? ? ? ? ? (d << 24) | (c << 16) | (b << 8) | a
>> +#endif
>
> This is missing parens everywhere. ?I'm also uncertain whether it
> might not be better to use #if HAVE_BIGENDIAN instead. ?You never know
> with compilers...

That one I'm not too worried about, don't we require it to do that
correctly (symbol elimination) in allcodecs.c?

Brackets around the whole operation added.

Ronald
-------------- next part --------------
A non-text attachment was scrubbed...
Name: h264pred_vp8_functions.patch
Type: application/octet-stream
Size: 9457 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100622/a82f7cb3/attachment.obj>