[FFmpeg-devel] [PATCH] VP8 decoder

[Ronald S. Bultje]

Hi,

On Tue, Jun 15, 2010 at 10:22 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Tue, Jun 15, 2010 at 09:12:30AM -0400, David Conrad wrote:
>> +static void pred4x4_vertical_vp8_c(uint8_t *src, const uint8_t *topright, int stride){
>> + ? ?const int lt= src[-1-1*stride];
>> + ? ?LOAD_TOP_EDGE
>> + ? ?LOAD_TOP_RIGHT_EDGE
>> +
>> + ? ?// 32-bit stores maybe
>
> yes

Fixed, I think (I wanted to use AV_WN32() instead of AV_WL/B32, so I
had to introduce a macro to write the four bytes in the correct order,
doesn't something like that already exist somewhere?).

>> @@ -539,6 +610,20 @@ static void pred16x16_plane_rv40_c(uint8_t *src, int stride){
>> ? ? ?pred16x16_plane_compat_c(src, stride, 0, 1);
>> ?}
>>
>> +static void pred16x16_tm_vp8_c(uint8_t *src, int stride){
>> + ? ?uint8_t *cm = ff_cropTbl + MAX_NEG_CROP;
>> + ? ?int tl = src[-1-stride];
>> + ? ?uint8_t *top = src-stride;
>> + ? ?int x, y;
>> +
>> + ? ?for (y = 0; y < 16; y++) {
>> + ? ? ? ?int l = src[-1];
>> + ? ? ? ?for (x = 0; x < 16; x++)
>> + ? ? ? ? ? ?src[x] = cm[l + top[x] - tl];
>
> &cm[l - tl]
> can be factored out

Fixed also. New patch for h264pred attached, plus separate reindent.

Ronald
-------------- next part --------------
A non-text attachment was scrubbed...
Name: h264pred_vp8_functions.patch
Type: application/octet-stream
Size: 8807 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100622/47cd84b8/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: h264pred_vp8_functions_reindent.patch
Type: application/octet-stream
Size: 2452 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100622/47cd84b8/attachment-0001.obj>