[FFmpeg-devel] [PATCH] Fix segfault in x11grab when drawing Cursor on Xservers that don't support the XFixes extension

[Michael Niedermayer]

On Tue, Jun 22, 2010 at 10:41:59PM +1000, Brenden Bain wrote:
> On Tue, 2010-06-22 at 12:08 +0100, M?ns Rullg?rd wrote:
> > Brenden Bain <brenden.bain at gmail.com> writes:
> > 
> > > Reformatted and changed information message printing when XFixes not
> > > available to "Unable to query cursor shape. Using "arrow" mouse
> > > cursor."
> > 
> > I would apply just the checks for the extension being present first,
> > and add the fallback static image afterwards.
> > 
> 
> Sorry, its not 100% clean to me what you mean here. Do you mean two
> patches? If you want two patches the simplest fix is probably to just do
> a "!= NULL" check. 

i dunno about mans but i would like to see the crash fixed and once thats
done any new features could be considered depending on how widespread the
need for them is.


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Into a blind darkness they enter who follow after the Ignorance,
they as if into a greater darkness enter who devote themselves
to the Knowledge alone. -- Isha Upanishad
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100622/2fc13d3f/attachment.pgp>