[FFmpeg-devel] [PATCH] Allow setting options on URLContexts before opening the connection

[Martin Storsjö]

On Tue, 22 Jun 2010, Michael Niedermayer wrote:

> On Mon, Jun 21, 2010 at 12:24:16PM +0300, Martin Storsj? wrote:
> > On Mon, 21 Jun 2010, Michael Niedermayer wrote:
> > 
> > > On Mon, Jun 21, 2010 at 11:36:58AM +0300, Martin Storsj? wrote:
> [...]
> > +int url_open_protocol (URLContext **puc, struct URLProtocol *up,
> > +                       const char *filename, int flags)
> > +{
> > +    int ret;
> > +
> > +    ret = url_alloc_for_protocol(puc, up, filename, flags);
> > +    if (ret)
> > +        goto fail;
> > +    ret = url_connect(*puc);
> 
> > +    if (ret)
> > +        goto fail;
> > +    return ret;
> > + fail:
> 
> dejavu ...

Agh, 10l to me, fixed this one too.

> >  
> >  /**
> >   * Creates an URLContext for accessing to the resource indicated by
> > + * url, but doesn't initiate the connection yet.
> > + *
> > + * @param puc pointer to the location where, in case of success, the
> > + * function puts the pointer to the created URLContext
> > + * @param flags flags which control how the resource indicated by url
> > + * is to be opened
> > + * @return 0 in case of success, a negative value corresponding to an
> > + * AVERROR code in case of failure
> 
> i think this would be more readable with empty lines or some other form of
> seperation between 2 @tags

This is copypasted from the url_open doxy, so I'll leave it in the same 
form as that one - people interested in cleaning it up into some 
particular form can do it for both then.

> except these ok
> also update to APIChanges and minor bump may be wanted at some point

Yes, I'll do those when applying it. Thanks!

// Martin