[FFmpeg-devel] [PATCH] hqdn3d libavfilter port

[Michael Niedermayer]

On Mon, Jun 21, 2010 at 09:13:04PM +0200, Stefano Sabatini wrote:
> On date Sunday 2010-06-20 18:08:25 -0700, Baptiste Coudurier encoded:
[...]
> > +#include "avfilter.h"
> > +#include "libavutil/pixdesc.h"
> > +
> > +#define PARAM1_DEFAULT 4.0
> > +#define PARAM2_DEFAULT 3.0
> > +#define PARAM3_DEFAULT 6.0
> > +
> > +typedef struct {
> > +    int Coefs[4][512*16];
> > +    unsigned int *Line;
> > +    unsigned short *Frame[3];
> > +    int hsub, vsub;
> > +} HQDN3DContext;
> 
> general style note: avoid camelCasing, use plain_c_style, if_( and
> for_( are preferred and I see weird indent in many places.

as long as the filter exists in mplayer we should try to keep our code as
close to it as possible to make future merging of changes back and forth
easier.
Once mplayer supports libavfilter and the filter is droped from libmpcodecs
we can do cosmetic cleanup together with any maintainer the filter might
have had in mplayer, but currently its really not a good idea

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Avoid a single point of failure, be that a person or equipment.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100622/fcd551dc/attachment.pgp>