[FFmpeg-devel] [PATCH 2/3] Support DTS-ES extension (XCh) in dca

Nick Brereton nick
Mon Jun 21 00:39:11 CEST 2010


On Sun, 2010-06-20 at 22:12 +0000, Carl Eugen Hoyos wrote:
> Nick Brereton <nick <at> nbrereton.net> writes:
> 
> > -/*        static float pcm_to_double[8] =
> > -            {32768.0, 32768.0, 524288.0, 524288.0, 0, 8388608.0, 8388608.0};*/
> >           qmf_32_subbands(s, k, subband_samples[k], &s->samples[256 *
>  s->channel_order_tab[k]],
> > -                            M_SQRT1_2*s->scale_bias
>  /*pcm_to_double[s->source_pcm_res] */ ,
> > -                            s->add_bias );
> > +                         M_SQRT1_2*s->scale_bias, s->add_bias);
> 
> That's at least one cosmetic change iiuc that must not be mixed with functional
> changes. When fixing, please also change all for( and if( to "for (" and "if (".
> 
> Carl Eugen
> 

Modified as suggested; existing code does have some "if(" and "for("
constructs that I don't touch - I'll create a separate patch to clean up
those after this lot (given that they're cosmetic).
-------------- next part --------------
A non-text attachment was scrubbed...
Name: dca_move_code_ver2.patch
Type: text/x-patch
Size: 13846 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100620/4f9d9820/attachment.bin>



More information about the ffmpeg-devel mailing list