[FFmpeg-devel] [PATCH] Remove useless preprocessor directives.

[Benoit Fouet]

On Thu, 17 Jun 2010 21:02:08 +0200 Michael Niedermayer wrote:
> On Thu, Jun 17, 2010 at 03:32:02PM +0200, Benoit Fouet wrote:
> > yuv420_bgr32 and yuva420_bgr32 are only used if HAVE_7REGS is set.
> > The other solution would be to add an #else case.
> > 
> > This fixes the following warnings:
> > In file included from libswscale/x86/yuv2rgb_mmx.c:55:
> > libswscale/x86/yuv2rgb_template.c: In function ?yuva420_rgb32_MMX?:
> > libswscale/x86/yuv2rgb_template.c:410: warning: no return statement in function returning non-void
> > libswscale/x86/yuv2rgb_template.c: In function ?yuva420_bgr32_MMX?:
> > libswscale/x86/yuv2rgb_template.c:453: warning: no return statement in function returning non-void
> > In file included from libswscale/x86/yuv2rgb_mmx.c:62:
> > libswscale/x86/yuv2rgb_template.c: In function ?yuva420_rgb32_MMX2?:
> > libswscale/x86/yuv2rgb_template.c:410: warning: no return statement in function returning non-void
> > libswscale/x86/yuv2rgb_template.c: In function ?yuva420_bgr32_MMX2?:
> > libswscale/x86/yuv2rgb_template.c:453: warning: no return statement in function returning non-void
> > ---
> >  x86/yuv2rgb_template.c |    4 ----
> >  1 files changed, 0 insertions(+), 4 deletions(-)
> 
> if this patch works iam ok with it but i think it will break with some
> gcc on x86_32
> 

Well, it works on mine :)
But yes, I suspect it would break on some configurations (as it has not
been put in place just for the fun of it)

What about the other alternative? Too ugly a workaround?

Ben