[FFmpeg-devel] [PATCH] dsputil: add bswap16_buf()

[Michael Niedermayer]

On Thu, Jun 17, 2010 at 11:54:01PM +0200, Michael Niedermayer wrote:
> On Thu, Jun 17, 2010 at 08:34:09PM +0100, M?ns Rullg?rd wrote:
> > Michael Niedermayer <michaelni at gmx.at> writes:
> > 
> > > On Thu, Jun 17, 2010 at 06:34:04PM +0100, M?ns Rullg?rd wrote:
> > >> Michael Niedermayer <michaelni at gmx.at> writes:
> > >> 
> > >> > On Thu, Jun 17, 2010 at 11:43:44AM +0100, M?ns Rullg?rd wrote:
> > >> >> Michael Niedermayer <michaelni at gmx.at> writes:
> > >> >> 
> > >> >> > On Thu, Jun 17, 2010 at 11:24:11AM +0100, M?ns Rullg?rd wrote:
> > >> >> >> Mans Rullgard <mans at mansr.com> writes:
> > >> >> >> 
> > >> >> >> > ---
> > >> >> >> >  libavcodec/dsputil.c |    7 +++++++
> > >> >> >> >  libavcodec/dsputil.h |    1 +
> > >> >> >> >  2 files changed, 8 insertions(+), 0 deletions(-)
> > >> >> >> 
> > >> >> >> Is anyone fundamentally opposed to this?  If not, can we please just
> > >> >> >> apply it and figure out the required alignment later?
> > >> >> >
> > >> >> > without the alignment being documented its not possible to implement it
> > >> >> > efficiently, thus useless
> > >> >> 
> > >> >> No more useless than having a dozen copies of that loop scattered
> > >> >> about the code.
> > >> >
> > >> > Sorry but you cant block badly needed changes without any constructive
> > >> > comment on what is wrong with them so they could be fixed.
> > >> 
> > >> You're the one doing the blocking here.
> > >
> > > you have done great work on arm optimizations and also the build system
> > > but theres a limit to the amount of trolling attacks and fillibustering
> > > that ill swallow
> > >
> > > its you blocking the code and everyone can just read
> > > Re: [FFmpeg-devel] [PATCH] lavfi test for 1-1 filters pixel format output
> > > to see that himself
> > 
> > That's not blocking anyone but me.  It works on native builds, which
> > is what everybody else is doing.
> 
> its not working for me:
> @@ -1,2 +1,2 @@
> -4ffe30abe99931bc9989f40ae65654b7 *./tests/data/lavfi/crop_scale.nut
> +e3fd245595dba1a119a2532f5d423517 *./tests/data/lavfi/crop_scale.nut
>  8941454 ./tests/data/lavfi/crop_scale.nut
> make: *** [regtest-crop_scale] Error 1
> 
> also stefanos patch for example changes:
> @@ -261,7 +261,7 @@ LAVFI_TESTS =           \
>      vflip               \
>      vflip_crop          \
>      vflip_vflip         \
> -#   lavfi_pix_fmts      \
> +    lavfi_pix_fmts      \
> 
> that does not look like a native vs cross compile thing

also its not run on fate AFAIK and that would be usefull just to know
why it fails for me.
does it fail everywhere? just on x86_64? nowhere, thus a local issue
on my tree?
The reg tests (lavfi and stream copy and all that) are very important
as related development would benefit if they are in place and working

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Good people do not need laws to tell them to act responsibly, while bad
people will find a way around the laws. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100617/e9559754/attachment.pgp>