[FFmpeg-devel] [PATCH] dsputil: add bswap16_buf()

[Michael Niedermayer]

On Thu, Jun 17, 2010 at 11:43:44AM +0100, M?ns Rullg?rd wrote:
> Michael Niedermayer <michaelni at gmx.at> writes:
> 
> > On Thu, Jun 17, 2010 at 11:24:11AM +0100, M?ns Rullg?rd wrote:
> >> Mans Rullgard <mans at mansr.com> writes:
> >> 
> >> > ---
> >> >  libavcodec/dsputil.c |    7 +++++++
> >> >  libavcodec/dsputil.h |    1 +
> >> >  2 files changed, 8 insertions(+), 0 deletions(-)
> >> 
> >> Is anyone fundamentally opposed to this?  If not, can we please just
> >> apply it and figure out the required alignment later?
> >
> > without the alignment being documented its not possible to implement it
> > efficiently, thus useless
> 
> No more useless than having a dozen copies of that loop scattered
> about the code.

or blocking libavfilter development due to refusing to tell where a bug
is that you found during review
or blocking a selftest needed for stream copy testing which is needed
for fixing stream copy bugs.

Sorry but you cant block badly needed changes without any constructive
comment on what is wrong with them so they could be fixed.
And then on the other hand expect me to accept half digested new API
that due to lacking of 1 line of text cannot be implemented.

please send code that is remotely close to the quality you expect from
people working on your scripts.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Dictatorship naturally arises out of democracy, and the most aggravated
form of tyranny and slavery out of the most extreme liberty. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100617/7f24e126/attachment.pgp>