[FFmpeg-devel] [PATCH] RTP H.264 / AVC support

[Luca Abeni]

On 06/16/2010 10:08 AM, Howard Chu wrote:
> Luca Abeni wrote:
>> It was just an idea... I attach a still-not-finished (works for me, but
>> it's still unclean in some parts... In particular, I still need to reuse
>> the avc_mp4_find_startcode() in other places) patch, which gives the
>> idea.
>> The good point about it is that it's simple.
>
> Simple is good... It looks nice, and if it works, great.
>
> A side comment - I know a smart compiler will eliminate common
> subexpressions for you, but it still bothers me to see "buf1 + size"
> everywhere, instead of just assigning it once at the beginning:
> uint8_t *end = buf1 + size;

Well, I probably tend to trust the compilers too much :)
(but I've never seen any compiler repeating this kind of computations,
when optimisations are enabled...)

Anyway, there is no problem in adding the "end" variable (but this goes
in a second patch).


				Luca