[FFmpeg-devel] Correct libvorbis.c behaviour with >2 channels

[Martin Storsjö]

On Thu, 3 Jun 2010, James Darnley wrote:

> On 3 June 2010 00:08, Justin Ruggles <justin.ruggles at gmail.com> wrote:
> >
> >
> > There are some patches on the issue tracker that might be useful.
> >
> > https://roundup.ffmpeg.org/issue1325
> >
> > This was only for 5.1 channels though. ?The vorbis spec has been
> > modified since then to support up to 7.1 I think... or more?
> >
> 
> Yes, it now has mappings for 1-8 channels.
> 
> Any comments about putting the following in vorbis_data.c?
> 
> >const uint8_t ff_vorbis_encoding_channel_layout_offsets[8][8] = {
> >    { 0, },
> >    { 0, 1, },
> >    { 0, 2, 1, },
> >    { 0, 1, 2, 3, },
> >    { 0, 2, 1, 3, 4, },
> >    { 0, 2, 1, 4, 5, 3, },
> >    { 0, 2, 1, 5, 6, 4, 3, },
> >    { 0, 2, 1, 6, 7, 4, 5, 3},
> >};
> 
> Also, what should I do if someone tries to use more that 8 channels.
> Libvorbis appears to support it.  Should this wrapper support it too
> or return an error?

Ping - I'd like to see this one fixed.

// Martin