[FFmpeg-devel] [PATCH] HE-AAC v2 decoder try 2

[Reimar Döffinger]

On Mon, Jun 14, 2010 at 05:10:25PM -0400, Alex Converse wrote:
> On Mon, Jun 14, 2010 at 3:35 PM, Reimar D?ffinger
> <Reimar.Doeffinger at gmx.de> wrote:
> > On Mon, Jun 14, 2010 at 03:00:03PM -0400, Alex Converse wrote:
> >> *transpose in/out as been folded into the filterbanks.
> >> *ipd/opd smoothing is now done with table lookups.
> >> *hybrid2_re optimized for zero values
> >> *old comments cleaned up
> >> *debugging av_noinline qualifiers removed
> >> *various other complaints have been addressed
> >
> > Well, you could try using the hardcoded-tables-generator
> > framework and flame me for anything that's missing from its
> > doc/tablegen.txt
> > I can do that conversion as well, in case you don't have objections
> > on principle, it just would be a way to ensure the documentation
> > (and possibly also the code itself) gets better if someone else
> > tries to use it...
> 
> Well for starters it seems to be missing support for 3d arrays.

You can add one or just do it manually, e.g. by calling the 2d function
in a loop and adding a few extra {} and ',' (basically exactly the same
code as the WRITE_2D_FUNC macro generates, just one argument more).