[FFmpeg-devel] [PATCH] libvpx: deadline & profile support

[Rafaël Carré]

On Mon, 14 Jun 2010 16:20:20 -0400
James Zern <jzern at google.com> wrote:

> Index: libavcodec/libvpxenc.c
> ===================================================================
> --- libavcodec/libvpxenc.c	(revision 23607)
> +++ libavcodec/libvpxenc.c	(working copy)
> @@ -276,7 +276,29 @@ static av_cold int vp8_init(AVCodecConte
> +    if (avctx->profile != FF_PROFILE_UNKNOWN)
> +        enccfg.g_profile = avctx->profile;

avcodec.h only defines AAC and H264 profiles, so the meaning of
enccfg.g_profile is private?

note that mpeg1/2 video decoder uses 'profile == 0' for 4:2:2 chroma and
4 for 4:2:0. value 1 is "High" profile.

profile is also used in mpeg4 video encoder with private values (i
suppose they come from the spec)


Shouldn't profile values be documented, and moved near the codec id
definition to which they apply (see attachment) ?

-- 
Rafa?l Carr?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: move-profile-defines.diff
Type: text/x-patch
Size: 1589 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100614/843ca36b/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100614/843ca36b/attachment.pgp>