[FFmpeg-devel] [PATCH] lavfi test for 1-1 filters pixel format output

[Måns Rullgård]

Stefano Sabatini <stefano.sabatini-lala at poste.it> writes:

> On date Sunday 2010-06-06 01:30:16 +0200, Stefano Sabatini encoded:
>> On date Wednesday 2010-06-02 23:42:32 +0200, Stefano Sabatini encoded:
>> > On date Monday 2010-05-24 22:12:25 +0100, M?ns Rullg?rd encoded:
>> > > Stefano Sabatini <stefano.sabatini-lala at poste.it> writes:
>> > [...]
>> > > >> Did I review this?  Of course not, or I would have told you it breaks
>> > > >> cross-builds (only if the test is run of course).
>> > > >
>> > > > Michael asked to commit, I did since the test is disabled so people
>> > > > can start to work out the lavfi bugs.
>> > > 
>> > > He also asked me to review it.
>> > > 
>> > > > Feel free to fix it yourself or point out the problem it has.
>> > > 
>> > > I'll get to it eventually, but the problem is that the executable you
>> > > build has to be run with $TARGET_EXEC and $TARGET_PATH.
>> > 
>> > Uhm, if that is true why tiny_psnr in regression-funcs.sh is not
>> > defined like that.
>> > 
>> > Anyway my main problem seems that the lavfi-showfiltfmts I'm using
>> > needs to include and link against the libav* libraries, in this being
>> > different from the other testprogs, so it is failing to compile and I
>> > don't even know if this crossbuilding thing is even able to support
>> > that requirement.
>> > 
>> > Your help is welcome, regards.
>> 
>> M?ns-ping.
>
> I'll apply this patch or a variant in three days if I get no reply.

You will do no such thing.  The patch is WRONG.

-- 
M?ns Rullg?rd
mans at mansr.com