[FFmpeg-devel] [PATCH] IFF: Add the HAM stuff

[Stefano Sabatini]

On date Wednesday 2010-05-26 23:24:30 +0200, Sebastian Vater encoded:
> Michael Niedermayer a ?crit :
> > id like to get rid of the macros.
> > aka no grep #define matches ;)
> >   
> 
> Ok, so fixed by making them functions. :-)
> 
> BTW, the thing about extract_header. I tried it and it didn't really
> remove duplicate code (we just missed out that the av_log in both cases
> outputs different textual message, too).
> 
> So for now I just fixed the macros. If you have an idea how to really
> shorten that extract_macro, please tell me.
> I'll fix that tomorrow then (I'm really tired now and will go to bed
> soon, so sorry).
> 
> If it's OK though with extract_headers, then just tell. ;-)
> 
> -- 
> 
> Best regards,
>                    :-) Basty/CDGS (-:
> 

> diff --git a/libavcodec/iff.c b/libavcodec/iff.c
> index 5791034..3f91a3d 100644
> --- a/libavcodec/iff.c
> +++ b/libavcodec/iff.c
[...]
>  typedef struct {
>      AVFrame frame;
>      int planesize;
>      uint8_t * planebuf;
>      int init; // 1 if buffer and palette data already initialized, 0 otherwise
> +    uint8_t * ham_buf;      ///< temporary buffer for planar to chunky conversation

Nit: *ham_buf;

[...]

Missing ChangeLog entry, rest looks OK to me.

Please also provide a link to an HAM sample which can be played with
this patch.

Regards.
-- 
FFmpeg = Fantastic & Fanciful Majestic Pure Everlasting Geek