[FFmpeg-devel] [PATCH] Add CRC check to ALS decoder

[Thilo Borgmann]

Am 12.06.10 21:08, schrieb Justin Ruggles:
> Thilo Borgmann wrote:
> 
>>>> CRC check for the ALS decoder.
>>>>
>>>> Works fine on my Intel-driven architecture. Any tests on other archs are
>>>> of course appreciated.
>>> I'm pretty sure the CRC for 24-bit source files are calculated based on
>>> 3-byte samples, not 4-byte samples.  I don't think your patch would work
>>> in this case.  Have you tested this with 24-bit source files?
>>
>> Sorry, indeed not. Revision 1 is tested against the 24 bit conformance
>> files.
>>
>> Still, I would appreciate if someone can test it on a non-intel arch
>> (before FATE does...).
> 
> Maybe the patch could be simplified and some macros avoided by doing
> something like:
> 
> int swap = HAVE_BIGENDIAN != sconf->msb_first;
> ...
> if (swap)
>     bswap_##bps##(...)
> ...

Good idea.

$> cat als_crc.rev1.patch | /dev/brain > als_crc.rev2.patch
$>

Thanks!
Thilo
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: als_crc.rev2.patch
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100613/8f7c4710/attachment.asc>