[FFmpeg-devel] [PATCH 2/2] Add ID support for .oma/.aa3

Ramiro Polla ramiro.polla
Sun Jun 13 11:01:04 CEST 2010


On Sun, Jun 13, 2010 at 2:20 AM, Reimar D?ffinger
<Reimar.Doeffinger at gmx.de> wrote:
> On Sun, Jun 13, 2010 at 12:25:13AM +0200, Michael Karcher wrote:
>> I'm really sorry for the time you invested for pointing me to that
>> stupid line.
>
> Don't worry too much about that.
> Anyway, I at least see no more mistakes/issues...

> -    ret = get_buffer(s->pb, buf, 10);
> -    if (ret != 10)
> -        return -1;
> +    ff_id3v2_read(s, ID3v2_EA3_MAGIC);
> +    ret = get_buffer(s->pb, buf, EA3_HEADER_SIZE);

Shouldn't a dependency on id3v2.o be added to the Makefile as well?



More information about the ffmpeg-devel mailing list