[FFmpeg-devel] [PATCH] do not set codec tag in raw video encoder

[Baptiste Coudurier]

On 6/9/10 11:38 AM, Michael Niedermayer wrote:
> On Wed, Jun 09, 2010 at 02:47:21AM -0700, Baptiste Coudurier wrote:
>> On 6/5/10 3:35 PM, Baptiste Coudurier wrote:
>>> Hi
>>>
>>> $subject, let the muxer choose the appropriate one depending on the
>>> format.
>>>
>>>
>>> rawenc_codec_tag.patch
>>>
>>>
>>> Index: libavcodec/rawenc.c
>>> ===================================================================
>>> --- libavcodec/rawenc.c	(revision 23498)
>>> +++ libavcodec/rawenc.c	(working copy)
>>> @@ -35,8 +35,6 @@
>>>        avctx->coded_frame->pict_type = FF_I_TYPE;
>>>        avctx->coded_frame->key_frame = 1;
>>>        avctx->bits_per_coded_sample =
>>> av_get_bits_per_pixel(&av_pix_fmt_descriptors[avctx->pix_fmt]);
>>> -    if(!avctx->codec_tag)
>>> -        avctx->codec_tag = avcodec_pix_fmt_to_codec_tag(avctx->pix_fmt);
>>>        return 0;
>>>    }
>>>
>>
>> Any objection ?
>
> i suspect this might break muxing rawvideo in some containers
> also it does not seem to be completely in line with the api documentation
> in avcodec.h for codec_tag

Maybe, though currently muxing rawvideo in mov is broken if the pix_fmt 
is in the table, it will choose an avi fourcc which will choke in 
av_write_header.

[...]

-- 
Baptiste COUDURIER
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
FFmpeg maintainer                                  http://www.ffmpeg.org