[FFmpeg-devel] [PATCH] ARM: remove useless stack push/pop

[Rafaël Carré]

On Wed, 09 Jun 2010 09:07:04 +0100
M?ns Rullg?rd <mans at mansr.com> wrote:

> >> > diff --git a/libavcodec/arm/jrevdct_arm.S
> >
> >> Does this function call any other functions?  If so, the stack must
> >> maintain 8-byte alignment, and this is the easiest way to
> >> accomplish that.  Not that you'd want to use that DCT
> >> implementation anyway.
> >
> > No it doesn't (stack pointer is modified a few lines below entry
> > anyway)
> 
> Does anything in the function require 8-byte alignment?  LDRD or so.

No it's simple armv4, no fancy instructions.

There was no 8-byte alignment anyway.

Thanks for asking anyway because I hadn't checked if it was the case
(I didn't know about this requirement)

-- 
Rafa?l Carr?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100609/0bf47d15/attachment.pgp>