[FFmpeg-devel] [PATCH] libvpx: add 2 pass setting mapping

[Jason Garrett-Glaser]

On Tue, Jun 8, 2010 at 12:17 PM, James Zern <jzern at google.com> wrote:
> On Tue, Jun 8, 2010 at 14:24, Jason Garrett-Glaser
> <darkshikari at gmail.com> wrote:
>> On Tue, Jun 8, 2010 at 11:09 AM, James Zern <jzern at google.com> wrote:
>>> The attached adds a mapping for libvpx/rc_2pass* based on comments
>>> from earlier thread "[PATCH] add encode options to libvpxenc"
>>> regarding use of qcompress.
>>>
>>> Descriptions of the libvpx settings:
>>> ? ? ? ? * Bias, expressed on a scale of 0 to 100, for determining target size
>>> ? ? ? ? * for the current frame. The value 0 indicates the optimal CBR mode
>>> ? ? ? ? * value should be used. The value 100 indicates the optimal VBR mode
>>> ? ? ? ? * value should be used. Values in between indicate which way the
>>> ? ? ? ? * encoder should "lean."
>>> ? ? ? ? rc_2pass_vbr_bias_pct
>>
>> This is *literally* qcomp: 0 is CBR, 1 is VBR, everything in between
>> lies along the scale. ?Any particular reason it can't map to qcomp?
>>
> Thought I did.
> + ? ?//0-100 (0 => CBR, 100 => VBR)
> + ? ?enccfg.rc_2pass_vbr_bias_pct ? ? ? ? ? = round(avctx->qcompress * 100);
>
> The above were descriptions of the libvpx values being mapped with
> this patch, sorry for the confusion.

Ah sorry, this is what I get for not actually reading the patch.

Dark Shikari