[FFmpeg-devel] [PATCH 2/2] Add ID support for .oma/.aa3
Michael Karcher
ffmpeg
Tue Jun 8 00:06:40 CEST 2010
Am Montag, den 07.06.2010, 23:51 +0200 schrieb Reimar D?ffinger:
> > + if(ff_id3v2_match(buf, ID3v2_EA3_MAGIC)) {
> > + buf += ff_id3v2_tag_len(buf);
> > + }
> > +
> > + if (!memcmp(buf, "EA3", 3) && !buf[4] && buf[5] == EA3_HEADER_SIZE)
> Uh, no buffer size check?
> And missing space after "if" and unnecessary {}
Oh, good point. I hope the attached patch fixes these issues.
Regards,
Michael Karcher
-------------- next part --------------
A non-text attachment was scrubbed...
Name: id3v2_for_oma.diff
Type: text/x-patch
Size: 3108 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100608/c3298358/attachment.bin>
More information about the ffmpeg-devel
mailing list