[FFmpeg-devel] [PATCH] options to set stream id (custom TS pid)

[Mike Scheutzow]

Thank you for your feedback.

Here are updated versions of both the ffmpeg.c and mpegtsenc.c patches.

> On Sun, Jun 06, 2010 at 01:48:51PM -0700, Baptiste Coudurier wrote:
>>> +
>>> +    memset( streamid_map, 0, sizeof(streamid_map) );
>>>   }
>> Parantheses placement.

I removed the two spaces.

>>> +        /* maintain compatibility for apps that set st->id to AVStream 
>>> index */
>>> +        if (st->id>= 16) {
>> This is not the reason, pid < 16 are reserved.

I changed the comment. I also rearranged the range check on st->id, 
which I think makes the intent more clear.

Note: the code does not error out for negative st->id value so that the 
muxer continues to behave the same way it used to for that case.


Mike Scheutzow
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: ffmpeg_set_streamid_v3.patch
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100607/3ff665ce/attachment.asc>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: mpegts_custom_pids_v4.patch
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100607/3ff665ce/attachment.txt>