[FFmpeg-devel] [PATCH] restoring binary compatibility with ffmpeg 0.5

[Michael Niedermayer]

On Sun, Jun 06, 2010 at 09:03:55PM +0200, Reinhard Tartler wrote:
> On So, Jun 06, 2010 at 20:01:44 (CEST), M?ns Rullg?rd wrote:
> 
> > Reinhard Tartler <siretart at tauware.de> writes:
> >
> >> On So, Jun 06, 2010 at 17:59:48 (CEST), M?ns Rullg?rd wrote:
> >>
> >>> Reinhard Tartler <siretart at tauware.de> writes:
[...]
> >>>> +__asm__(".symver ff_av_destruct_packet_nofree,av_destruct_packet_nofree at LIBAVFORMAT_52");
> >>>
> >>> This will break with non-gcc compilers and/or non-gnu assemblers, both
> >>> of which we support.
> >>
> >> I don't think so. I've changed the configure script so that this part
> >> gets only compiled if the toolchain actually supports versioning
> >> scripts. On non-gnu assemblers/compilers, this part doesn't get compiled
> >> at all.
> >
> > You are mistaken.  The configure test checks whether the _linker_
> > supports version scripts.  The code above relies on the _compiler_
> > supporting this particular inline asm syntax, which some supported
> > compilers do not, and on the _assembler_ supporting the .symver
> > directive, which again some supported assemblers do not.
> >
> > Can this be done in the version script instead?
> 
> no, it cannot.

whats the problem with adding the proper @LIBAVFORMAT_52? versioning to th
affected symbols in lavc?


> This .symver directive is a gnu extension to the sun
> implementation.

yes

besides whats the status of the linker fixes, has someone pushed them
upstream?

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The real ebay dictionary, page 2
"100% positive feedback" - "All either got their money back or didnt complain"
"Best seller ever, very honest" - "Seller refunded buyer after failed scam"
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100606/cfe2f394/attachment.pgp>