[FFmpeg-devel] [PATCH] make librtmp+ssl work with configure

[Luca Barbato]

On 06/06/2010 04:59 PM, M?ns Rullg?rd wrote:
> Reimar D?ffinger <Reimar.Doeffinger at gmx.de> writes:
> 
>> On Sun, Jun 06, 2010 at 02:33:02PM +0100, M?ns Rullg?rd wrote:
>>> Luca Barbato <lu_zero at gentoo.org> writes:
>>>
>>>> On 06/06/2010 12:26 PM, M?ns Rullg?rd wrote:
>>>>> I didn't know librtmp had all those options.  Anyhow, that doesn't
>>>>> excuse the use pkgconfig --cflags.
>>>>
>>>> Is this way better?
>>>>
>>>>>> pkg-config is handy from time to time =P
>>>>>
>>>>> It is still a flawed design with a broken implementation.
>>>>
>>>> Should be improved a lot, indeed.
>>>>
>>>>
>>>> diff --git a/configure b/configure
>>>> index 2949d30..79140dd 100755
>>>> --- a/configure
>>>> +++ b/configure
>>>> @@ -2618,7 +2618,7 @@ enabled libnut     && require  libnut libnut.h nut_demuxer_init -lnut
>>>>  enabled libopencore_amrnb  && require libopencore_amrnb opencore-amrnb/interf_dec.h Decoder_Interface_init -lopencore-amrnb -lm
>>>>  enabled libopencore_amrwb  && require libopencore_amrwb opencore-amrwb/dec_if.h D_IF_init -lopencore-amrwb -lm
>>>>  enabled libopenjpeg && require libopenjpeg openjpeg.h opj_version -lopenjpeg
>>>> -enabled librtmp    && require  librtmp librtmp/rtmp.h RTMP_Init -lrtmp
>>>> +enabled librtmp    && require  librtmp librtmp/rtmp.h RTMP_Init $(pkg-config --libs librtmp)
>>>>  enabled libschroedinger && add_cflags $(pkg-config --cflags schroedinger-1.0) &&
>>>>                             require libschroedinger schroedinger/schro.h schro_init $(pkg-config --libs schroedinger-1.0)
>>>>  enabled libspeex   && require  libspeex speex/speex.h speex_decoder_init -lspeex
>>>
>>> You've convinced me we don't have a choice here.
>>
>> well... We could try without pkg-config first, so it still works
>> without it for at least some cases.
>> While I'd prefer that, I can't blame you if you consider it too ugly...
> 
> I do think that would be unnecessarily ugly.
> 
committed then

-- 

Luca Barbato
Gentoo/linux
http://dev.gentoo.org/~lu_zero