[FFmpeg-devel] [PATCH 7/7] Add check in av_write_header() which validates the rawvideo codec tag.

[Stefano Sabatini]

On date Sunday 2010-06-06 13:42:02 +0200, Michael Niedermayer encoded:
> On Sun, Jun 06, 2010 at 01:01:31PM +0200, Michael Niedermayer wrote:
> > On Sun, Jun 06, 2010 at 10:52:35AM +0200, Stefano Sabatini wrote:
> > > On date Sunday 2010-06-06 05:03:57 +0200, Michael Niedermayer encoded:
> > > > On Sun, Jun 06, 2010 at 02:02:21AM +0200, Stefano Sabatini wrote:
> > > > > On date Sunday 2010-06-06 01:40:55 +0200, Michael Niedermayer encoded:
> > > > > > On Sat, Jun 05, 2010 at 09:46:07PM +0200, Stefano Sabatini wrote:
> > > > > > [...]
> > > > > > >  const AVCodecTag ff_nut_video_tags[] = {
> > > > > > > +    { CODEC_ID_RAWVIDEO, 0                         },
> > > > > > 
> > > > > > rejected
> > > > > > 
> > > > > > i keep saying the same thing and you keep doing the exact opposit.
> > > > > > i fixed it and ill add some reg test, 
> > > > > 
> > > > > It didn't fix neither NUT nor AVI. Please try this:
> > > > 
> > > > avi works, we have a regression test for it now
> > > > nut was what you worked on, if it doesnt work dont blame me.
> > > > and rgb444 was what you just added, so if that is the only format
> > > > not working in avi ...
> > > > 
> > > > avi worked in the past, and one of the recent patches broke it, and
> > > > exactly the way i repeatly told you you must be carefull with, namely codec_tag
> > > > must be 0 in avi for rgb you totally ignored me and ffmpeg generated
> > > > invalid files as a result. Now this patch might make invalid nut files
> > > > and you dont even attempt to explain why you would want add such a
> > > > incorrect codec_tag to nut.
> > > 
> > > I already posted the failing command, problem is that NUT/AVI muxers
> > > are creating files which cannot be played (rather than just fail). It
> > 
> > i already hinted that this is because you messed up.
> > i fixed rgb444 in avi now, you forgot to add it to a table
> 
> rgb444 in nut fixed too, again adding rgb444 to 2 tables

I remember you that I'm not the one which added rgb444. Anyway it's
still broken with rgb4_byte/bgr4_byte, I'll add the entries, but in
general there is no guarantee that per each FFmpeg pixel format has to
exist a corresponding NUT tag (indeed I had to add them to make the
lavfi test go smooth with the greatest possible number of formats, as
I did for rgb444).

Indeed this is going to break again anytime a new pixel format is
added, same for AVI.

Regards.
-- 
FFmpeg = Free and Fanciful Mythic Puristic Entertaining Gargoyle