[FFmpeg-devel] [PATCH] matroska: fix tagdefault value
Reimar Döffinger
Reimar.Doeffinger
Sun Jun 6 14:54:33 CEST 2010
Hello,
The specification says 0x4484 is the value for the TagDefault,
the 0x44B4 is just a typo in the tools!
This patch fixes it, keeping compatibility on the demuxer side:
Index: matroska.h
===================================================================
--- matroska.h (revision 23501)
+++ matroska.h (working copy)
@@ -148,7 +148,8 @@
#define MATROSKA_ID_TAGNAME 0x45A3
#define MATROSKA_ID_TAGSTRING 0x4487
#define MATROSKA_ID_TAGLANG 0x447A
-#define MATROSKA_ID_TAGDEFAULT 0x44B4
+#define MATROSKA_ID_TAGDEFAULT 0x4484
+#define MATROSKA_ID_TAGDEFAULT_BUG 0x44B4
#define MATROSKA_ID_TAGTARGETS 0x63C0
#define MATROSKA_ID_TAGTARGETS_TYPE 0x63CA
#define MATROSKA_ID_TAGTARGETS_TYPEVALUE 0x68CA
Index: matroskadec.c
===================================================================
--- matroskadec.c (revision 23501)
+++ matroskadec.c (working copy)
@@ -426,6 +426,7 @@
{ MATROSKA_ID_TAGSTRING, EBML_UTF8, 0, offsetof(MatroskaTag,string) },
{ MATROSKA_ID_TAGLANG, EBML_STR, 0, offsetof(MatroskaTag,lang), {.s="und"} },
{ MATROSKA_ID_TAGDEFAULT, EBML_UINT, 0, offsetof(MatroskaTag,def) },
+ { MATROSKA_ID_TAGDEFAULT_BUG, EBML_UINT, 0, offsetof(MatroskaTag,def) },
{ MATROSKA_ID_SIMPLETAG, EBML_NEST, sizeof(MatroskaTag), offsetof(MatroskaTag,sub), {.n=matroska_simpletag} },
{ 0 }
};
More information about the ffmpeg-devel
mailing list