[FFmpeg-devel] [PATCH] Pictor/PC Paint PIC decoder

[Peter Ross]

On Thu, Jun 03, 2010 at 08:59:11PM +0200, Reimar D?ffinger wrote:
> > +OBJS-$(CONFIG_PIC_DECODER)             += picdec.o cga_data.o
> > +    REGISTER_DECODER (PIC, pic);
> > +    CODEC_ID_PICTOR,
> 
> I don't really care, but wouldn't it be nicer to make the codec name match as well?
> 
> > +    int mask = (1 << bits_per_plane) - 1;
> > +    int shift = *plane * bits_per_plane;
> > +
> > +    while (run > 0) {
> > +        int j;
> > +        for (j = 8-bits_per_plane; j >= 0; j -= bits_per_plane) {
> > +            d = s->frame.data[0] + *y * s->frame.linesize[0];
> > +            d[*x] |= ((value >> j) & mask) << shift;
> 
> I think you missed my point.
> My suggestion was to do something like (could be simplified,
> I don't remember the type of value right now etc.):

Done.

-- Peter
(A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pic-r5.diff
Type: text/x-diff
Size: 11982 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100606/55d52a91/attachment.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100606/55d52a91/attachment.pgp>