[FFmpeg-devel] [PATCH 7/7] Add check in av_write_header() which validates the rawvideo codec tag.

[Michael Niedermayer]

On Sun, Jun 06, 2010 at 02:02:21AM +0200, Stefano Sabatini wrote:
> On date Sunday 2010-06-06 01:40:55 +0200, Michael Niedermayer encoded:
> > On Sat, Jun 05, 2010 at 09:46:07PM +0200, Stefano Sabatini wrote:
> > [...]
> > >  const AVCodecTag ff_nut_video_tags[] = {
> > > +    { CODEC_ID_RAWVIDEO, 0                         },
> > 
> > rejected
> > 
> > i keep saying the same thing and you keep doing the exact opposit.
> > i fixed it and ill add some reg test, 
> 
> It didn't fix neither NUT nor AVI. Please try this:

avi works, we have a regression test for it now
nut was what you worked on, if it doesnt work dont blame me.
and rgb444 was what you just added, so if that is the only format
not working in avi ...

avi worked in the past, and one of the recent patches broke it, and
exactly the way i repeatly told you you must be carefull with, namely codec_tag
must be 0 in avi for rgb you totally ignored me and ffmpeg generated
invalid files as a result. Now this patch might make invalid nut files
and you dont even attempt to explain why you would want add such a
incorrect codec_tag to nut.

The only problem i see is mov, and this could be a real issue that might
need some changes but here with avi and nut iam totally puzzled what problems
you have.
I guess i will have to look into it myself

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I know you won't believe me, but the highest form of Human Excellence is
to question oneself and others. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100606/88b6d6cf/attachment.pgp>