[FFmpeg-devel] [PATCH] Modifies doxy comments for strict_std_compliance in avcodec.h to improve grammar and readability

Michael Niedermayer michaelni
Sat Jun 5 22:46:49 CEST 2010


On Sat, Jun 05, 2010 at 09:31:30PM +0930, Rodney Baker wrote:
> On Sat, 5 Jun 2010 12:36:00 Michael Niedermayer wrote:
> > On Wed, Jun 02, 2010 at 09:51:24PM +0930, Rodney Baker wrote:
> > > $subj
> > > 
> > > This is my first patch submission - please be gentle :-).
> > > (I did the diff with kdesvn so I hope that it is in the right format - I
> > > haven't figured out how to tell it to use diff -up so I hope it does it
> > > by default).
> > > 
> > >  avcodec.h |   10 +++++-----
> > >  1 file changed, 5 insertions(+), 5 deletions(-)
> > > 
> > > 159f10691c188a107816a3b89744027d60451d4d  avcodec-h-20100602-1.diff
> > > Index: libavcodec/avcodec.h
> > > ===================================================================
> > > --- libavcodec/avcodec.h	(revision 23424)
> > > +++ libavcodec/avcodec.h	(working copy)
> > > @@ -1347,11 +1347,11 @@
> > > 
> > >       * - encoding: Set by user.
> > >       * - decoding: Set by user.
> > >       * Setting this to STRICT or higher means the encoder and decoder
> > >       will
> > > 
> > > -     * generally do stupid things. While setting it to inofficial or
> > > lower +     * generally do stupid things, whereas setting it to
> > > inofficial or lower -     * will mean the encoder might use things that
> > > are not supported by all +     * will mean the encoder might produce
> > > output that is not supported by all
> > > 
> > > -     * spec compliant decoders. Decoders make no difference between
> > > normal, +     * strictly spec-compliant decoders. Decoders don't
> > > differentiate between normal,
> > 
> > i think adding "strictly" changes the intended meaning
> > 
> > [...]
> 
> OK. Modified patch attached removing the word "strictly". 
> -- 
> ===================================================
> Rodney Baker VK5ZTV
> rodney.baker at iinet.net.au
> =================================================== 
> 

>  avcodec.h |   12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 3749e697d289e92be31242e3653d3a2b9713ee49  avcodec-h-20100605-1.diff

ok

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If you think the mosad wants you dead since a long time then you are either
wrong or dead since a long time.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100605/a951cd04/attachment.pgp>



More information about the ffmpeg-devel mailing list