[FFmpeg-devel] [PATCH] mp4toannexb modification / improvement

[Luca Abeni]

On 06/03/2010 11:39 PM, Michael Niedermayer wrote:
[...]
>> Hence, I propose to modify / enhance this filter to return the
>> converted extradata if no data is passed (that is, if buf_size
>> is 0). The "regular" behaviour of the filter is not affected
>> by this patch (the only difference is that if buf_size == 0 the
>> filter returns the converted extradata instead of failing), and
>> this patch allows to avoid a good amount of code duplication in
>> sdp.c...
>>
>> Is the patch ok? If not, what is needed to make it acceptable?
>
> why does the bsf not convert the extradata?
> i mean it leaves the extradata in "AVC" syntax

I do not know... My impression is that since the bsf "inlines"
the SPS and PPS (inserting them in the bitstream) it does not care
about converting the format of the extradata. But I am not sure;
maybe Benoit can clarify this point?


			Thanks,
				Luca