[FFmpeg-devel] [PATCH] VP8 de/encode via libvpx

[Michael Niedermayer]

On Thu, Jun 03, 2010 at 12:59:35PM -0400, James Zern wrote:
> On Thu, Jun 3, 2010 at 11:28, Michael Niedermayer <michaelni at gmx.at> wrote:
> > On Wed, Jun 02, 2010 at 06:22:53PM -0400, James Zern wrote:
> > [...]
> >> +static inline void cx_pktcpy(struct FrameListData *dst,
> >> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? const struct vpx_codec_cx_pkt *src)
> >> +{
> >> + ? ?dst->pts ? ? ?= src->data.frame.pts;
> >> + ? ?dst->duration = src->data.frame.duration;
> >> + ? ?dst->flags ? ?= src->data.frame.flags;
> >> + ? ?dst->sz ? ? ? = src->data.frame.sz;
> >> + ? ?dst->buf ? ? ?= src->data.frame.buf;
> >> +}
> >
> > why this function instead of
> > *dst= src->data.frame
> > ?
> >
> Different base types so this alone won't work. The FrameListData pulls
> some fields from the frame unnamed struct in vpx_codec_cx_pkt. Some
> casting could be done with the above but I don't know if that's for
> the best.

hmm, no its fine, patch should be ok from my point of view then

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I hate to see young programmers poisoned by the kind of thinking
Ulrich Drepper puts forward since it is simply too narrow -- Roman Shaposhnik
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100603/2d86f077/attachment.pgp>