[FFmpeg-devel] [PATCH] RTP H.264 / AVC support

[Luca Abeni]

Hi,

On 06/03/2010 12:45 AM, Howard Chu wrote:
[...]
>> The attached patch tries to explain how I think the sdp.c modifications
>> should look like (it does not address the rtpenc_h264.c modifications
>> yet). It uses a bitstream filter (and it requires a small modification /
>> improvement to the mp4toannexb bsf), because the SDP is written only one
>> time, before starting the stream... So a small memcopy and memory
>> reallocation cannot be a problem.
>> I ran some minimal tests, and it works here (maybe it fails in some
>> other cases, but it is just a proof of concept)
>
> OK, I've taken your patch and moved a few things around and run it thru
> patcheck. The only warning from it now is spurious (possibly unused var
> which is definitely used).

Ok; good to see that we are finally converging :)
I do not like some of your changes to the sdp.c patch, but to find a
tradeoff I think I can live with them.
I'll split the h264_mp4toannexb_bsf.c part, and repost it for review;
then, when it is accepted I'll commit the sdp.c part (after adding a
check for "bsfc == NULL", which is still missing).

After that, we can move to the rtpenc* part (yesterday I tried my
ff_avc_find_startcode_avc() idea, and I think it can allow to simplify
the code a little bit). In particular, I am still not sure about the
need for the "NALP" data type.


			Luca