[FFmpeg-devel] [PATCH 7/7] Add check in av_write_header() which validates the rawvideo codec tag.

Stefano Sabatini stefano.sabatini-lala
Wed Jun 2 19:35:47 CEST 2010


On date Tuesday 2010-06-01 19:59:55 +0200, Michael Niedermayer encoded:
> On Tue, Jun 01, 2010 at 07:29:34PM +0200, Stefano Sabatini wrote:
[...]
> what is unclear on
> rgb in avi must use codec_tag=0 ?
> the raw rgb format in avi is indicated by the number of bits per pixel
> not by the fourcc which must be set to 0.
> 
> 
> > 
> > What the code currently implements is just wrong for both AVI and NUT,
> > in the case of AVI if the pixel format cannot be mapped to any codec
> > tag, codec_tag is set to 0,
> 
> it must be 0 this is as it should be
> 
> 
> > which when reading it is interpreted as
> > YUV420P,
> 
> if so thats a bug and i would suspect a new one

A possible fix for nut attached.

Regards.
-- 
FFmpeg = Fostering and Fascinating Mere Powered Extensive Geisha



More information about the ffmpeg-devel mailing list