[FFmpeg-devel] Correct libvorbis.c behaviour with >2 channels

[Martin Storsjö]

On Wed, 2 Jun 2010, Michael Niedermayer wrote:

> On Fri, May 28, 2010 at 07:57:54PM +0200, James Darnley wrote:
> > I fail hard at sending out correct patches.  New one, git format-patch
> 
> > From 1325bfbc5240cec90937f3d26f2663073050ccda Mon Sep 17 00:00:00 2001
> > From: James Darnley <james.darnley at gmail.com>
> > Date: Fri, 28 May 2010 14:36:53 +0200
> > Subject: [PATCH 2/3] Fix libvorbis encoding with more than 2 channels
> > 
> > ---
> >  libavcodec/Makefile    |    2 +-
> >  libavcodec/libvorbis.c |   12 +++++-------
> >  2 files changed, 6 insertions(+), 8 deletions(-)
> 
> if the bug and fix are confirmed then this should be ok

The actual bug with more than one channel is obviously fixed by this, but 
this also remaps the channels, and I'm not really sure if this is the 
correct way.

Robert, Alex, or anyone else that are familiar with mapping of channels in 
these kinds of codecs - care to give a comment on this?

// Martin