[FFmpeg-devel] [PATCH] RTP H.264 / AVC support

[Howard Chu]

Luca Abeni wrote:
> On 05/30/2010 08:41 PM, Howard Chu wrote:
>> Only 3 lines of code in rtpenc.c were copied literally from h264.c.
>
> Regarding the previous patch you are mentioning: yes, maybe only 3 lines
> are literally copied. But then look at the modifications you introduced
> to ff_rtp_send_h264(), and compare them with libavcodec/h264.c:decode_nal_units()
> (around line 2768 and following...).
>
> Moreover, the code introduced in ff_rtp_send_h264() and in sdp.c:extradata2psets()
> did the same thing (split an "AVC format" frame in NALs) using slightly
> different code (compare "len = (len<<  8) | *r++;" with "nalsize = AV_RB16(r);").
>
> Regarding the new patch: as I said, I do not think this
> ff_avc_parse_nal_units_inplace() is the correct thing to simplify the code.
> (moreover, I am still convinced that this function does the same things
> done by the h264.c code I mentioned above).

OK, this set of patches consolidates the code using a callback function.

-- 
   -- Howard Chu
   CTO, Symas Corp.           http://www.symas.com
   Director, Highland Sun     http://highlandsun.com/hyc/
   Chief Architect, OpenLDAP  http://www.openldap.org/project/
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: h264.txt
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100601/c2b18a65/attachment.txt>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: rtp.txt
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100601/c2b18a65/attachment-0001.txt>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: sdp.txt
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100601/c2b18a65/attachment-0002.txt>