[FFmpeg-devel] [PATCH] swscale-test: add md5 output

Ramiro Polla ramiro.polla
Sun Aug 1 00:31:20 CEST 2010


On Sat, Jul 31, 2010 at 7:27 PM, Vitor Sessak <vitor1001 at gmail.com> wrote:
> On 07/31/2010 11:10 PM, Ramiro Polla wrote:
>> On Sun, Jul 25, 2010 at 9:54 PM, Michael Niedermayer<michaelni at gmx.at>
>> ?wrote:
>>> On Sat, Jul 24, 2010 at 02:10:32PM -0300, Ramiro Polla wrote:
>
> [...]
>
>>> SSE of 123 does not implicate that there is no change to a previous SSE
>>> of 123
>>> and a change of CRC does tell nothing of the SSE
>>
>> For regression tests we want a checksum to be bitexact (I'll send a
>> patch to add the bitexact flag to sws_flags later), and in this case
>> the SSE doesn't matter.
>
> It does, because every time there is a patch that is expected to change the
> CRC (and thus update the reference output of the tests) it is easy to know
> if it improves or reduce the PSNR by just looking at the diff of the
> reference file. That's the reason why "make test" prints also the
> psnr/stddev.

Hm, I was hoping that whenever the checksum changed, the dev would
himself run swscale-test -sse...

So do you think it'd be best to always print out both checksum and sse?



More information about the ffmpeg-devel mailing list