[FFmpeg-devel] [RFC] replace some static with asm_visibility or so

[Michael Niedermayer]

On Sun, Jan 27, 2008 at 03:53:52PM +0100, Reimar D?ffinger wrote:
> Hello,
> On Sun, Jan 27, 2008 at 03:10:39PM +0100, Reimar D?ffinger wrote:
> > as you may know current code does not compile with ICC and assembler due
> > to it optimizing away all the constants.
> > I wonder if you'd find it acceptable to replace all the "static"
> > attributes by a define, e.g. "asm_visibility" that would be static by
> > default but empty for any compilers that cannot handle it (actually, I'd
> > be just happy with having it defined to static always, a one line change
> > seems ok to me to compile with a different compiler, just not the
> > current situation).
> 
> On second though, something like
> #define DECLARE_ASM_CONST(n,t,v) static const t v attribute_used __attribute__ ((aligned (n)))
> might work out nicer (less clutter).
> Also makes sure nobody uses something global, non-const from asm code without
> thinking.
> Opinions, alternatives?

probably ok

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have never wished to cater to the crowd; for what I know they do not
approve, and what they approve I do not know. -- Epicurus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080127/310f7d07/attachment.pgp>