[FFmpeg-devel] [PATCH] attachments support in matroska demuxer

[Evgeniy Stepanov]

On Sunday 27 January 2008 06:57:42 Michael Niedermayer wrote:
> On Sat, Jan 26, 2008 at 09:13:22PM +0300, Evgeniy Stepanov wrote:
> > On Sunday 20 January 2008 04:56:20 Michael Niedermayer wrote:
> > [...]
> >
> > > iam against some undocumented char *type
> > > please document precissely what it repressents and how it differs from
> > > codec_tag, stream_codec_tag and codec_id
> > > or even better get rid of it and use codec_tag or explain why the type
> > > here should be special cased relative to these funny codec id strings
> > > in matroska
> > >
> > > filename should be documented as well, and in stream type independant
> > > way like the "source filename" of the stream or so
> >
> > [...]
> >
> > * AVStream.type removed
> > * more types added to ff_mkv_mime_tags
> > * AVStream.filename comment added
> >
> > It is fine now ?
>
> [...]
>
> > +
> > +    /* source filename of the stream */
> > +    char *filename;
>
> not doxygen compatible
>
>
> [...]
>
> > +/* IDs in the attachments master */
> > +#define MATROSKA_ID_ATTACHEDFILE	 0x61A7
> > +#define MATROSKA_ID_FILENAME		 0x466E
> > +#define MATROSKA_ID_FILEMIMETYPE	 0x4660
> > +#define MATROSKA_ID_FILEDATA		 0x465C
> > +#define MATROSKA_ID_FILEUID		 0x46AE
>
> tabs are forbidden in svn
>
> and i cant speak for the matroska part but the libav* part looks mostly ok
>
> [...]

Fixed.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: attachments3.patch
Type: text/x-diff
Size: 10153 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080127/60ffc848/attachment.patch>