[FFmpeg-devel] [PATCH] libavformat/mov.c memleak bugfix

[Michael Niedermayer]

On Sat, Jan 26, 2008 at 02:22:08AM +0100, Baptiste Coudurier wrote:
> Zdenek Kabelac wrote:
> > 2008/1/26, M?ns Rullg?rd <mans at mansr.com>:
> >> "Zdenek Kabelac" <zdenek.kabelac at gmail.com> writes:
> >>
> > 
> >>> If the avformat.h  specify in the comment that only alllocated memory
> >>> block could be used as a priv_data - than everything is fine and
> >>> release could be done in generic stream_close code -  it is that
> >>> simple....
> >>>
> >>> It's just not set clearly - so the priv_date might be used for
> >>> unpredictable data.
> >> The priv_data pointer in AVStream, which I assume you are referring
> >> to, is managed by each (de)muxer.  Nobody else has any business
> >> touching it.  That's what priv(ate) means.
> > 
> > Of course - that's clear I guess for everyone this list.
> > 
> > But it's upto to the (de)muxer how it will be used - and so far
> > (de)muxer could use it to store anything it needs. When the pointer
> > freeing will be placed into the generic close function and not into
> > the codec - than I would expect this would be somewhere for the
> > (de)muxer writter.
> > 
> > I hope it's now much more clear...
> > 
> 
> So far av_write_trailer free priv_data for AVStream, I thought it was
> more consistent to do the same for demuxers.

yes

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The greatest way to live with honor in this world is to be what we pretend
to be. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080126/865b4b07/attachment.pgp>