[FFmpeg-devel] [PATCH] to support newer neAAC for libfaadbin

[Måns Rullgård]

"Zdenek Kabelac" <zdenek.kabelac at gmail.com> writes:

> 2008/1/24, M?ns Rullg?rd <mans at mansr.com>:
>> "Zdenek Kabelac" <zdenek.kabelac at gmail.com> writes:
>>
>> > 2008/1/24, M?ns Rullg?rd <mans at mansr.com>:
>> >>
>> >> Zdenek Kabelac wrote:
>> >> > Hi
>> >> >
>> >> > Here is a small patch to adapt libfaad.c binary version to link
>> >> > properly with newer header file (it was generating wrong symbol names)
>> >> >
>> >> > Patch also unifies error messages with just one prefix FAAD library
>> >> > and aligns one wrongly indented line in the source file.
>>
>> > 2. Unified logging prefix
>>
>> I'm not sure I agree with this.  I'm all for consistency, but
>> prefixing messages like this is redundant as the context pointer
>> passed to av_log() already identifies the caller.
>
> Well its up to you - it just should look a bit more consistent...
>
> This remined me one minor thing - this small patch safes couple of
> bytes in our multigigabyte world these days ;)

> -    do { static const char* n = AV_STRINGIFY(faacDec ## a);             \
> +    do { static const char n[] = AV_STRINGIFY(faacDec ## a);            \

I'd be surprised if this resulted in any difference at all in the
compiled code.  Rather than micro-optimising things like that, feel
free to clean it up a bit instead.  It's a total mess as is.  Oh wait,
it was you who wrote it to begin with...

-- 
M?ns Rullg?rd
mans at mansr.com