[FFmpeg-devel] [PATCH] to support newer neAAC for libfaadbin
Måns Rullgård
mans
Thu Jan 24 20:59:25 CET 2008
"Zdenek Kabelac" <zdenek.kabelac at gmail.com> writes:
> 2008/1/24, M?ns Rullg?rd <mans at mansr.com>:
>>
>> Zdenek Kabelac wrote:
>> > Hi
>> >
>> > Here is a small patch to adapt libfaad.c binary version to link
>> > properly with newer header file (it was generating wrong symbol names)
>> >
>> > Patch also unifies error messages with just one prefix FAAD library
>> > and aligns one wrongly indented line in the source file.
>>
>> Unrelated changes in single patch => won't review.
>
> Well if that makes your life happier -
>
> 1. BIN version adaptation for new function names
Fixed differently.
> 2. Unified logging prefix
I'm not sure I agree with this. I'm all for consistency, but
prefixing messages like this is redundant as the context pointer
passed to av_log() already identifies the caller.
> 3. Simple indent change
Fixed more thoroughly.
Finally, don't top-post.
--
M?ns Rullg?rd
mans at mansr.com
More information about the ffmpeg-devel
mailing list