[FFmpeg-devel] [PATCH] add coded_channels to audio api

[Michel Bardiaux]

Michael Niedermayer a ?crit :
> On Sun, Jan 06, 2008 at 01:36:48AM -0500, Justin Ruggles wrote:

[snip]

>> Index: ffmpeg.c
>> ===================================================================
>> --- ffmpeg.c	(revision 11431)
>> +++ ffmpeg.c	(working copy)
>> @@ -2722,8 +2722,8 @@
>>                  if(str && (opt->flags & AV_OPT_FLAG_AUDIO_PARAM) && (opt->flags & AV_OPT_FLAG_DECODING_PARAM))
>>                      av_set_string(enc, opt_names[j], str);
>>              }
>> -            //fprintf(stderr, "\nInput Audio channels: %d", enc->channels);
>> -            audio_channels = enc->channels;
>> +            //fprintf(stderr, "\nInput Audio channels: %d", enc->coded_channels);

Also, this should not be fprintf but av_log. Even if commented out.

>> +            audio_channels = enc->coded_channels;
>>              audio_sample_rate = enc->sample_rate;
>>              if(audio_disable)
>>                  ic->streams[i]->discard= AVDISCARD_ALL;
> 
> i think this should be in a seperate patch (same for ffplay.c)
> and did you test both normal transcoding and stream copy with request!=coded!=channels
> ?
[snip]


-- 
Michel Bardiaux
R&D Director
T +32 [0] 2 790 29 41
F +32 [0] 2 790 29 02
E mailto:mbardiaux at mediaxim.be

Mediaxim NV/SA
Vorstlaan 191 Boulevard du Souverain
Brussel 1160 Bruxelles
http://www.mediaxim.com/