[FFmpeg-devel] [PATCH] Disable puts and change it to av_log

[Aurelien Jacobs]

Diego Biurrun wrote:

> On Thu, Jan 17, 2008 at 01:12:01AM +0100, Michael Niedermayer wrote:
> > On Wed, Jan 16, 2008 at 11:28:08PM +0100, Diego Biurrun wrote:
> > > 
> > > Attached patch OK to commit then?
> > 
> > no
> > 
> > the code you add in mace.c is just wrong
> 
> This one should be good.
> 
> [...]
> 
> -#ifdef DEBUG
> -puts("mace_decode_frame[3]()");
> -#endif
> +        dprintf(avctx,"mace_decode_frame[3]()");
                       ^^^
No space after comma.

> -#ifdef DEBUG
> -puts("mace_decode_frame[6]()");
> -#endif
> +        dprintf(avctx, "mace_decode_frame[6]()");
                       ^^^^
One space after comma.

Not very consistent.
To me, this don't seem harder than adding correct punctuation
or capitals in commit messages :p.

Aurel