[FFmpeg-devel] [PATCH] add alloc_put_byte function

Baptiste Coudurier baptiste.coudurier
Mon Jan 14 13:44:34 CET 2008


Baptiste Coudurier wrote:
> Hi Reimar,
> 
> Reimar D?ffinger a ?crit :
>> Hello,
>> On Fri, Dec 21, 2007 at 09:49:05AM +0100, Reimar D?ffinger wrote:
>>> On Thu, Dec 20, 2007 at 11:58:32PM +0100, Baptiste Coudurier wrote:
>>> [...]
>>>> For consistency, can we choose a naming convention ?
>>>>
>>>> We got:
>>>> avcodec_alloc_context
>>>> av_alloc_format_context
>>>>
>>>> Furthermore, ByteIOContext can be used to read data, so naming it
>>>> alloc_put_byte seems somehow odd to me.
>>> I just went on analogy to init_put_byte, I don't like it particularly
>>> either. I'll go with anything you agree on ;-)
>> Applied with only av_ prefix added, I do not want to wait forever with a
>> depending patch.
>> Feel free to come up with a better name and then bump the lavf version
>> (I originally just forgot to do it, but now think it might be good as it
>> give as chance to change the name without breaking API in the strict
>> sense ;-) ).
>>
> 
> Ok, I already suggested av_alloc_byteio_context, anyone against it ?
> 

I'll apply the following patch in a few hours.

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
SMARTJOG S.A.                                    http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
Phone: +33 1 49966312
-------------- next part --------------
A non-text attachment was scrubbed...
Name: alloc_byteio.patch
Type: text/x-diff
Size: 1609 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080114/a8ddb423/attachment.patch>



More information about the ffmpeg-devel mailing list