[FFmpeg-devel] [PATCH] Bunch of accumulated patches...

[Michael Niedermayer]

On Sun, Jan 13, 2008 at 07:44:41PM +0100, Sigbj?rn Skj?ret wrote:
> Ok, here's some old and some new patches, resubmitting old ones due to being
> eaten by the ML earlier for not being subscribed (I am now subscribed, but I do
> not receive mails, so if you wish me to reply to something CC me, thanks).
> 

> av_fast_realloc.diffs: Since all the other mem-funcs have been moved to avutil
> this one really belongs there as well...

this is no reason to make it part of the public API of libavutil


> 
> averror.diffs changes AVERROR_NOFMT to use a commonly available define instead
> (arbitrarily chosen, anything would do), however as this might be viewed as
> breaking ABI there's also averror2.diffs which will define EILSEQ if it doesn't
> exist already. Pick the one you like the best...

libav* cannot #define standard E* in a public header
also arbitrarily choosen E* as error codes is not acceptable


> 
> broken_mergel.diffs: This is a regression-fix, fixes erroneously (and broken)
> applied defines when compiling with AltiVec-enabled GCC2.

this might be ok, altivec maintainer?


> 
> missingconsts.diffs: Adds a couple of missing consts (one which could break
> linking under certain conditions).

ok


> 
> rationaldecls.diffs: Enclose directly applied AVRationals in parenthesis to
> avoid preprocessing issues (ok, this one is really specific to my build since I
> have defines for those funcs, but it doesn't hurt anyway and perhaps increases
> readability slightly).

fix whatever you do with the preprocessor

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The greatest way to live with honor in this world is to be what we pretend
to be. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080113/dd35fef5/attachment.pgp>